Skip to content

Conversation

@reez
Copy link
Collaborator

@reez reez commented Jan 16, 2024

Description

Use new FeeRate type in TxBuilder per #437 (comment) in #437

"For another PR, but now that we have the FeeRate type, let's use it in the TxBuilder the same way it's used in Rust bdk."

Notes to the reviewers

I think I've completed the requested changes via:

  • Updated wallet.rs to use FeeRate type in TxBuilder
  • Added from_sat_per_vb + from_sat_per_kwu for the ability to construct a FeeRate
  • Updated tests across all 4 platforms (using the new from_sat_per_vb)

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez force-pushed the issue-438 branch 5 times, most recently from a86649e to 4fbec67 Compare January 19, 2024 16:49
@reez reez linked an issue Jan 19, 2024 that may be closed by this pull request
@reez reez marked this pull request as ready for review January 19, 2024 19:50
@reez reez requested a review from thunderbiscuit January 19, 2024 19:51
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8e9d2dd.

@thunderbiscuit thunderbiscuit merged commit 8e9d2dd into bitcoindevkit:master Jan 22, 2024
@reez reez deleted the issue-438 branch January 22, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use new FeeRate type in TxBuilder

2 participants